Cleanup to syntax::print/rustc::hir::print #62098
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
I don't understand the larger picture of excising So r=me on that. |
|
That said, cc @petrochenkov and @eddyb. |
|
The larger goal is mostly just a simplification of the code, which may lead to both compile time wins ( |
|
@bors r+ |
|
📌 Commit 0091e6e has been approved by |
bors
added
S-waiting-on-bors
| @@ -259,7 +259,7 @@ pub fn mk_printer<'a>(out: Box<dyn io::Write+'a>, linewidth: usize) -> Printer<' | |||
| } | |||
|
|
|||
| pub struct Printer<'a> { | |||
| out: Box<dyn io::Write+'a>, | |||
| out: &'a mut Vec<u8>, | |||
This is in preparation for a removal of
io::Result<()>from all of the printing infrastructure methods (separate PR due to huge diff), along with potentially some other cleanups.r? @Centril (but feel free to reassign if there's someone better -- there's no functional changes here)