-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: Enable use_extern_macros
in 2018 edition
#52472
Conversation
This was previously enabled via `proc_macro`, but since `proc_macro` is now stable this is no longer the case. Explicitly include it in the 2018 edition here.
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup |
📌 Commit 5ecec1c has been approved by |
…=petrochenkov rustc: Enable `use_extern_macros` in 2018 edition This was previously enabled via `proc_macro`, but since `proc_macro` is now stable this is no longer the case. Explicitly include it in the 2018 edition here.
Rollup of 13 pull requests Successful merges: - #51628 (use checked write in `LineWriter` example) - #52116 (Handle array manually in str case conversion methods) - #52218 (Amend option.take examples) - #52418 (Do not use desugared ident when suggesting adding a type) - #52439 (Revert some changes from #51917 to fix custom libdir) - #52455 (Fix doc comment: use `?` instead of `.unwrap()`) - #52458 (rustc: Fix a suggestion for the `proc_macro` feature) - #52464 (Allow clippy to be installed with make install) - #52472 (rustc: Enable `use_extern_macros` in 2018 edition) - #52477 (Clarify short-circuiting behvaior of Iterator::zip.) - #52480 (Cleanup #24958) - #52487 (Don't build twice the sanitizers on Linux) - #52510 (rustdoc: remove FIXME about macro redirects) Failed merges: r? @ghost
What are we supposed to do when we hit this error for a derive or proc macro crate? |
Okay so this warning is totally broken, since it doesn't handle internal macros at all. This means even crates like lazy_static do not compile. |
Alright now I'm just confused 😄 I'm unable to get this to work on clippy, but just using lazy_static outside of clippy works, so I need to poke at this a bit more 😄
|
This was previously enabled via
proc_macro
, but sinceproc_macro
is nowstable this is no longer the case. Explicitly include it in the 2018 edition
here.