Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Enable use_extern_macros in 2018 edition #52472

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

alexcrichton
Copy link
Member

This was previously enabled via proc_macro, but since proc_macro is now
stable this is no longer the case. Explicitly include it in the 2018 edition
here.

This was previously enabled via `proc_macro`, but since `proc_macro` is now
stable this is no longer the case. Explicitly include it in the 2018 edition
here.
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2018
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 18, 2018

📌 Commit 5ecec1c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jul 18, 2018
…=petrochenkov

rustc: Enable `use_extern_macros` in 2018 edition

This was previously enabled via `proc_macro`, but since `proc_macro` is now
stable this is no longer the case. Explicitly include it in the 2018 edition
here.
bors added a commit that referenced this pull request Jul 19, 2018
Rollup of 13 pull requests

Successful merges:

 - #51628 (use checked write in `LineWriter` example)
 - #52116 (Handle array manually in str case conversion methods)
 - #52218 (Amend option.take examples)
 - #52418 (Do not use desugared ident when suggesting adding a type)
 - #52439 (Revert some changes from #51917 to fix custom libdir)
 - #52455 (Fix doc comment: use `?` instead of `.unwrap()`)
 - #52458 (rustc: Fix a suggestion for the `proc_macro` feature)
 - #52464 (Allow clippy to be installed with make install)
 - #52472 (rustc: Enable `use_extern_macros` in 2018 edition)
 - #52477 (Clarify short-circuiting behvaior of Iterator::zip.)
 - #52480 (Cleanup #24958)
 - #52487 (Don't build twice the sanitizers on Linux)
 - #52510 (rustdoc: remove FIXME about macro redirects)

Failed merges:

r? @ghost
@bors bors merged commit 5ecec1c into rust-lang:master Jul 19, 2018
@Manishearth
Copy link
Member

What are we supposed to do when we hit this error for a derive or proc macro crate? use serde_derive::Deserialize does not work.

@Manishearth
Copy link
Member

Okay so this warning is totally broken, since it doesn't handle internal macros at all. This means even crates like lazy_static do not compile.

@Manishearth
Copy link
Member

Alright now I'm just confused 😄

I'm unable to get this to work on clippy, but just using lazy_static outside of clippy works, so I need to poke at this a bit more 😄

$ cargo +629d891499bca79aeb8ea079f756c566fdabbd3e build
   Compiling clippy_lints v0.0.212 (file:///home/manishearth/mozilla/Wall/rust-clippy/clippy_lints)                       
error: cannot find macro `__lazy_static_internal!` in this scope==>    ] 59/63: clippy_lints                              
  --> clippy_lints/src/utils/conf.rs:73:1
   |
73 | / lazy_static! {
74 | |     static ref ERRORS: Mutex<Vec<Error>> = Mutex::new(Vec::new());
75 | | }
   | |_^
   |
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

@alexcrichton alexcrichton deleted the macros-edition-2018 branch July 19, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants