Calculate the exact capacity for 2 HashMaps #52435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
approved these changes
Jul 16, 2018
src/librustc_driver/profile/trace.rs
Outdated
| @@ -220,7 +220,8 @@ pub fn write_counts(count_file: &mut File, counts: &mut HashMap<String,QueryMetr | |||
| } | |||
|
|
|||
| pub fn write_traces(html_file: &mut File, counts_file: &mut File, traces: &Vec<Rec>) { | |||
| let mut counts : HashMap<String,QueryMetric> = HashMap::new(); | |||
| let capacity = traces.iter().fold(0, |acc, t| acc + 1 + t.extent.len()); | |||
| let mut counts : HashMap<String,QueryMetric> = HashMap::with_capacity(capacity); | |||
There was a problem hiding this comment.
Missing comma between String and QueryMetric.
|
📌 Commit 20d7ffa7b9cec959c53dd67646068901766648e0 has been approved by |
bors
added
S-waiting-on-bors
|
No problem, done. |
kennytm
removed
the
S-waiting-on-bors
|
@bors r=estebank |
|
📌 Commit d85bcef has been approved by |
bors
added
the
S-waiting-on-bors
nnethercote
reviewed
Jul 17, 2018
| @@ -51,7 +51,7 @@ pub fn build(build: &mut Build) { | |||
| build_krate("", build, &mut resolves, "src/libtest"); | |||
| build_krate(&build.rustc_features(), build, &mut resolves, "src/rustc"); | |||
|
|
|||
| let mut id2name = HashMap::new(); | |||
| let mut id2name = HashMap::with_capacity(build.crates.len()); | |||
| for (name, krate) in build.crates.iter() { | |||
| id2name.insert(krate.id.clone(), name.clone()); | |||
| } | |||
There was a problem hiding this comment.
For what it's worth, this one could also be done with map() followed by collect().
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jul 17, 2018
Calculate the exact capacity for 2 HashMaps
bors
added a commit
that referenced
this pull request
Jul 17, 2018
Rollup of 9 pull requests Successful merges: - #52286 (Deny bare trait objects in src/librustc_errors) - #52306 (Reduce the number of clone()s needed in obligation_forest) - #52338 (update miri) - #52385 (Pass edition flags to compiler from rustdoc as expected) - #52392 (AsRef doc wording tweaks) - #52430 (update nomicon) - #52434 (Enable incremental independent of stage) - #52435 (Calculate the exact capacity for 2 HashMaps) - #52446 (Block beta if clippy breaks.) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.