Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct import suggestions for edition 2018 #52204

Merged
merged 1 commit into from
Jul 10, 2018
Merged

correct import suggestions for edition 2018 #52204

merged 1 commit into from
Jul 10, 2018

Conversation

zackmdavis
Copy link
Member

For #52202.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Jul 10, 2018

Isn't the crate prefix also valid 2015 Rust?

@zackmdavis
Copy link
Member Author

It's feature-gated.

zmd@ReflectiveCoherence:~/Code/Misc$ rustc import_suggestion.rs --edition 2015
error[E0658]: `crate` in paths is experimental (see issue #45477)
 --> import_suggestion.rs:1:5
  |
1 | use crate::inner_mod::MyInnerStruct;
  |     ^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 10, 2018

Oh. Right

r=me with a FIXME comment that references #45477

@zackmdavis zackmdavis force-pushed the and_the_crate_of_the_missing_module branch from e988a5e to 96b151b Compare July 10, 2018 06:22
@zackmdavis
Copy link
Member Author

Updated ("FIXME: may also be stabilized for Rust 2015 (Issues #45477, #44660)").

@oli-obk
Copy link
Contributor

oli-obk commented Jul 10, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jul 10, 2018

📌 Commit 96b151b has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2018
@bors
Copy link
Contributor

bors commented Jul 10, 2018

⌛ Testing commit 96b151b with merge e46bfa2...

bors added a commit that referenced this pull request Jul 10, 2018
@bors
Auto merge of #52204 - zackmdavis:and_the_crate_of_the_missing_module…
e46bfa2 
…, r=oli-obk

correct import suggestions for edition 2018

For #52202.
@bors
Copy link
Contributor

bors commented Jul 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing e46bfa2 to master...

@bors bors merged commit 96b151b into rust-lang:master Jul 10, 2018
@zackmdavis zackmdavis deleted the and_the_crate_of_the_missing_module branch July 10, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zackmdavis @rust-highfive @oli-obk @bors