Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in From, Into, Cursor docs #37393

Closed
wants to merge 2 commits into from
Closed

Fix links in From, Into, Cursor docs #37393

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 25, 2016

Tidied up some more issues with quote/bracket nesting. These are the last ones that I could easily find.

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -178,14 +178,14 @@ pub trait Into<T>: Sized {
/// ```
/// # Generic impls
///
/// - `From<T> for U` implies `[Into<U>] for T`
/// - `From<T> for U` implies [`Into<U>`]` for T`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand why this change is useful...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see how this renders here. Basically you can't have links inside code blocks.

Before:

  • From<T> for U implies [Into<U>] for T

After:

  • From<T> for U implies Into<U>for T

@GuillaumeGomez
Copy link
Member

Just a point which needs explanation otherwise it's all good.

@ollie27
Copy link
Member

ollie27 commented Oct 25, 2016

I've also fixed these as part of #37316.

@ghost
Copy link
Author

ghost commented Oct 25, 2016

@ollie27 Thanks and well spotted! This pull is a dupe then.

@ghost ghost closed this Oct 25, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants