Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Contributing.md: Added mention of make tidy #36241

Merged
merged 1 commit into from
Sep 7, 2016
Merged

doc: Contributing.md: Added mention of make tidy #36241

merged 1 commit into from
Sep 7, 2016

Conversation

Cobrand
Copy link
Contributor

@Cobrand Cobrand commented Sep 3, 2016

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Cobrand
Copy link
Contributor Author

Cobrand commented Sep 3, 2016

Related to #36191

@steveklabnik
Copy link
Member

@bors: r+ rollup

I wasn't sure about describing these as "style guidelines", but they are, just very, very crude ones 😄 Thanks!

@bors
Copy link
Contributor

bors commented Sep 6, 2016

📌 Commit 9d9c029 has been approved by steveklabnik

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 6, 2016
Rollup merge of rust-lang#36241 - Cobrand:contributing-md, r=stevekla…
c8140bd 
…bnik

doc: Contributing.md: Added mention of `make tidy`

r? @steveklabnik
@sophiajt sophiajt mentioned this pull request Sep 6, 2016
Merged
bors added a commit that referenced this pull request Sep 6, 2016
@bors
Auto merge of #36303 - jonathandturner:rollup, r=jonathandturner
3b272bf 
Rollup of 8 pull requests

- Successful merges: #36121, #36128, #36241, #36243, #36263, #36267, #36273, #36298
- Failed merges:
@bors bors merged commit 9d9c029 into rust-lang:master Sep 7, 2016
@Cobrand Cobrand deleted the contributing-md branch September 16, 2016 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cobrand @rust-highfive @steveklabnik @bors