Fully optimize by default #24205
Fully optimize by default #24205
Conversation
rust-installer never verifies.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Could we build jemalloc with |
|
@nrc done |
|
@bors: r+ 6d17c35 |
|
For some reason when I build with --enable-debug, llvm-mc doesn't get built. |
libLTO fails to link here.
|
I pushed a follow up that changes --enable-debug to not set --disable-optimize-llvm since I cannot get LLVM to build (libLTO linking fails) in that config. |
|
@bors r=alexcrichton |
|
📌 Commit a725426 has been approved by |
This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per rust-lang#17665. It does not add a `--enable-release` flag since that would be a no-op. cc @nrc Fixes rust-lang#22390 Fixes rust-lang#17081 Partially addresses rust-lang#17665
|
I still disagree with disabling LLVM asserts in nightlies. |
|
@nagisa Oh, I did mean to leave llvm asserts on for nightlies. I'll update it. |
|
@bors a=alexcrichton |
This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per rust-lang#17665. It does not add a `--enable-release` flag since that would be a no-op. cc @nrc Fixes rust-lang#22390 Fixes rust-lang#17081 Partially addresses rust-lang#17665
|
@brson yay! |
|
@bors: r+ |
|
📌 Commit 0e0c841 has been approved by |
This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per #17665. It does not add a `--enable-release` flag since that would be a no-op. cc @nrc Fixes #22390 Fixes #17081 Partially addresses #17665
|
This... was merged? Not sure what github is doing... Closing! |
|
Ah ha! I bet this is why my Filed #24405 |
This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per #17665. It does not add a
--enable-releaseflag since that would be a no-op.cc @nrc
Fixes #22390
Fixes #17081
Partially addresses #17665