Avoid unnecessary temporary on assignments #15145
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need the temporary when the type needs to be dropped, for other
types, we can use trans_into to directly place the value into the
destination.
This avoids some constructs that LLVM optimizes poorly because of partially
overlapping memcpys. Those currently appear, for example, when inserting a
value into a SmallIntMap.
Code:
Before:
After: