Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #134931

Merged
merged 10 commits into from
Dec 30, 2024
Merged

Rollup of 5 pull requests #134931

merged 10 commits into from
Dec 30, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

clubby789 and others added 10 commits December 29, 2024 03:31
Signed-off-by: ericlehong <193237094+ericlehong@users.noreply.github.com>
…jubilee

Add illumos target documentation

Fixes rust-lang#130132 (comment)

`@jclulow` `@pfmooney` I'm adding you as requested.

The page is very barebones (as I do not know illumos well) and could use some improvements (for example in the "Cross-compilation toolchains and C code" section).
Feel free to suggest improvements (or rewrite it from scratch) if you find something.
chore: fix typos

This PR fixes typos errors in docstring only, so functionality wise, it should stay the same.
Fix typos

This PR fixes typos errors in comments, docs and logs.

Thank you very much.
…obzol

ci: Cleanup docker build logs in CI

Cleaning up the CI logs to make reviewing CI failures easier. This PR adds a `::group` around the docker tag hash input which is pretty large (250+ lines) and is probably not relevant for most people.

Related to rust-lang#134910 , see this [comment](rust-lang#134910 (comment))
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 30, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Dec 30, 2024

📌 Commit 05c0cd3 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2024
@bors
Copy link
Contributor

bors commented Dec 30, 2024

⌛ Testing commit 05c0cd3 with merge 7f75bfa...

@bors
Copy link
Contributor

bors commented Dec 30, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7f75bfa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 30, 2024
@bors bors merged commit 7f75bfa into rust-lang:master Dec 30, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 30, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#132477 Add illumos target documentation 26899ec4bb985040041812f8a2ce30748d580f38 (link)
#134871 Add codegen test for issue 63646 d42913d64cc904bfc70cd2bfb46366fa32376ba1 (link)
#134911 chore: fix typos d8587657406e10ee241ef5b210ddf335605cbc10 (link)
#134922 Fix typos b451a51eda1b3a785ef54da11f6e57b694899876 (link)
#134924 ci: Cleanup docker build logs in CI 952e39431e4577cdbbe3f5d2f79ef7c81ebcd89f (link)

previous master: 2061630860

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7f75bfa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%, secondary -1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.8% [1.8%, 1.8%] 1
Improvements ✅
(primary)
-2.2% [-2.3%, -2.2%] 4
Improvements ✅
(secondary)
-2.4% [-3.1%, -1.4%] 3
All ❌✅ (primary) -2.2% [-2.3%, -2.2%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 759.925s -> 758.809s (-0.15%)
Artifact size: 325.47 MiB -> 325.55 MiB (0.02%)

@matthiaskrgr matthiaskrgr deleted the rollup-b47ly73 branch January 25, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants