Rollup of 9 pull requests

[fmease]

Successful merges:

• Add wasm_c_abi future-incompat lint #117918 (Add wasm_c_abi future-incompat lint)
• fix attribute validation on associated items in traits #121545 (fix attribute validation on associated items in traits)
• Split refining_impl_trait lint into _reachable, _internal variants #121720 (Split refining_impl_trait lint into _reachable, _internal variants)
• fix long-linker-command-lines failure caused by rust.rpath=false #122270 (fix long-linker-command-lines failure caused by rust.rpath=false)
• Delegation: fix ICE on duplicated associative items #122564 (Delegation: fix ICE on duplicated associative items)
• Remove obsolete parameter speculative from instantiate_poly_trait_ref #122577 (Remove obsolete parameter speculative from instantiate_poly_trait_ref)
• Optimize ptr::replace #122601 (Optimize ptr::replace)
• Mention jieyouxu for changes to compiletest, run-make tests and the run-make-support library #122604 (Mention jieyouxu for changes to compiletest, run-make tests and the run-make-support library)
• rustc-metadata: Store crate name in self-profile of metadata_register_crate #122605 (rustc-metadata: Store crate name in self-profile of metadata_register_crate)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[fmease]

@bors r+ rollup=never p=5

[bors]

📌 Commit caa6131 has been approved by fmease

It is now in the queue for this repository.

[bors]

⌛ Testing commit caa6131 with merge c8813dd...

[bors]

☀️ Test successful - checks-actions
Approved by: fmease
Pushing c8813dd to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#117918	Add wasm_c_abi future-incompat lint	93c473a1ec1ecc8f5dc8b1e9099425d081e4615e (link)
#121545	fix attribute validation on associated items in traits	ca3b995011807606822702fba622c19184ad49b5 (link)
#121720	Split refining_impl_trait lint into _reachable, _internal v…	18f8141884bb7efdb0a8e38c9023f4225b899af5 (link)
#122270	fix long-linker-command-lines failure caused by `rust.rpa…	48471efa4a88c279965bd8892c866b77f00a2c99 (link)
#122564	Delegation: fix ICE on duplicated associative items	1c3a29f751deb9824c55e4b362c0948f9f1ed911 (link)
#122577	Remove obsolete parameter speculative from `instantiate_p…	d9c600c0855dc05c4f846dac6eada24c39a683d4 (link)
#122601	Optimize ptr::replace	6a5549c1d11fbf0362a8bab07646a589e05f65bf (link)
#122604	Mention jieyouxu for changes to compiletest, run-make tests…	3738be7a2ec18cca6bc5b6f4e5cfca1b2a1a459c (link)
#122605	rustc-metadata: Store crate name in self-profile of metadat…	ef7ad6f5136f327b948f222979bb47171f379c93 (link)

previous master: 4c1b9c3e2f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (c8813dd): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.7%, 1.7%]	1
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.3%	[-5.3%, -5.3%]	1
All ❌✅ (primary)	1.7%	[1.7%, 1.7%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	6.1%	[3.5%, 8.8%]	2
Regressions ❌ (secondary)	4.5%	[1.0%, 6.5%]	3
Improvements ✅ (primary)	-7.8%	[-7.8%, -7.8%]	1
Improvements ✅ (secondary)	-4.6%	[-4.6%, -4.6%]	1
All ❌✅ (primary)	1.5%	[-7.8%, 8.8%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.4%	[-5.1%, -3.8%]	2
All ❌✅ (primary)	1.9%	[1.9%, 1.9%]	1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.0%, 2.8%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.1%, 2.8%]	14

Bootstrap: 670.532s -> 669.642s (-0.13%)
Artifact size: 312.75 MiB -> 312.75 MiB (0.00%)

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Complete job name: skip if S-waiting-on-bors
##[group]Run # Fetch state and labels of PR
# Fetch state and labels of PR
# Or exit successfully if PR does not exist
JSON=$(gh pr view cargo_update --repo $GITHUB_REPOSITORY --json labels,state || exit 0)
STATE=$(echo "$JSON" | jq -r '.state')
WAITING_ON_BORS=$(echo "$JSON" | jq '.labels[] | any(.name == "S-waiting-on-bors"; .)')

# Exit with error if open and S-waiting-on-bors
if [[ "$STATE" == "OPEN" && "$WAITING_ON_BORS" == "true" ]]; then
fi
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

[workingjubilee]

Huh. Didn't expect anything to actually be different here. Most likely candidate was

@rust-timer build 6a5549c

[rust-timer]

Finished benchmarking commit (6a5549c): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.7%, 1.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.7%	[1.7%, 1.7%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	6.0%	[2.6%, 9.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.0%	[-8.0%, -2.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[-8.0%, 9.3%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.8%	[-8.8%, -6.8%]	6
All ❌✅ (primary)	1.8%	[1.8%, 1.8%]	1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.0%, 3.1%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.1%, 3.1%]	14

Bootstrap: 670.532s -> 667.427s (-0.46%)
Artifact size: 312.75 MiB -> 312.72 MiB (-0.01%)

[Kobzol]

#122601 should in theory enable more LLVM optimizations, so regressing a single opt-full benchmark is fine to me.

@rustbot label: +perf-regression-triaged