Code

Rollup of 9 pull requests#120375

Code

Merged

bors merged 137 commits intorust-lang:masterrust-lang/rust:masterfrom matthiaskrgr:rollup-ueakvmsmatthiaskrgr/rust:rollup-ueakvmsCopy head branch name to clipboardJan 26, 2024

+3,182-1,361

Commits

Commits on Oct 31, 2023

• Make allow_internal_unstable work with stmt_expr_attributes

  Jules-Bertholet

  committed
  42b1406

  Copy full SHA for 42b1406

Commits on Nov 7, 2023

• read_zero_byte_vec refactor for better heuristics

  dswij

  committed
  8c79f78

  Copy full SHA for 8c79f78

• Stabilize slice_group_by

  Show description for 0bccdb3
  niklasf

  committed
  0bccdb3

  Copy full SHA for 0bccdb3

Commits on Nov 17, 2023

• Improve slice_group_by doc wording

  niklasf

  committed
  c5c2fb1

  Copy full SHA for c5c2fb1

Commits on Jan 2, 2024

• Make HirEqInterExpr::eq_block take comments into account

  Show description for 543d569
  ARandomDev99

  committed
  543d569

  Copy full SHA for 543d569

Commits on Jan 9, 2024

• Documentation edits for arc_with_non_send_sync

  Show description for c2d071c
  talagrand

  authored
  c2d071c

  Copy full SHA for c2d071c

Commits on Jan 11, 2024

• Fix error warning span for issue12045

  cocodery

  committed
  7c389ac

  Copy full SHA for 7c389ac

• Stop using DiagnosticBuilder::buffer in the parser.

  Show description for fb83ef6
  nnethercote

  committed
  fb83ef6

  Copy full SHA for fb83ef6

• Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

  flip1995

  committed
  aa220c7

  Copy full SHA for aa220c7

• Fix suggestion for map_clone on types implementing Copy

  GuillaumeGomez

  committed
  82841aa

  Copy full SHA for 82841aa

• Add new ui tests for map_clone lint on types implementing Copy

  GuillaumeGomez

  committed
  74db4b7

  Copy full SHA for 74db4b7

• I'm not on vacation (again)

  blyxyas

  committed
  85364e5

  Copy full SHA for 85364e5

• Auto merge of rust-lang#119864 - matthiaskrgr:rollup-mc2qz13, r=matthiaskrgr

  Show description for 6baa129
  bors

  committed
  6baa129

  Copy full SHA for 6baa129

• Auto merge of rust-lang#12132 - blyxyas:not-on-vacation-again, r=xFrednet

  Show description for c537134
  bors

  committed
  c537134

  Copy full SHA for c537134

• Auto merge of rust-lang#12129 - GuillaumeGomez:map-clone-copy, r=llogiq

  Show description for 88b5d51
  bors

  committed
  88b5d51

  Copy full SHA for 88b5d51

Commits on Jan 12, 2024

• check rust lints when an unknown lint is detected

  chenyukang

  committed
  1485e5c

  Copy full SHA for 1485e5c

• Delegation implementation: step 1

  Bryanskiy

  committed
  09d0241

  Copy full SHA for 09d0241

• [useless_asref]: check that the clone receiver is the local

  y21

  committed
  153b83f

  Copy full SHA for 153b83f

• Rollup merge of rust-lang#119819 - chenyukang:yukang-fix-118183-lint, r=davidtwco

  Show description for e9f8713
  GuillaumeGomez

  authored
  e9f8713

  Copy full SHA for e9f8713

• Fix false positive in PartialEq check in unconditional_recursion lint

  GuillaumeGomez

  committed
  c8cd09a

  Copy full SHA for c8cd09a

• Add regression ui test for unconditional_recursion lint on PartialEq

  GuillaumeGomez

  committed
  1326672

  Copy full SHA for 1326672

• Auto merge of rust-lang#12137 - GuillaumeGomez:fix-unconditional_recursion-false-positive, r=llogiq

  Show description for 7eca5af
  bors

  committed
  7eca5af

  Copy full SHA for 7eca5af

• Improve help message for search_is_some lint

  GuillaumeGomez

  committed
  68aceee

  Copy full SHA for 68aceee

• Update ui tests for search_is_some lint

  GuillaumeGomez

  committed
  37947ff

  Copy full SHA for 37947ff

• Improve let_underscore_lock

  Show description for 3b7ba1d
  Noratrieb

  committed
  3b7ba1d

  Copy full SHA for 3b7ba1d

• Auto merge of rust-lang#12140 - GuillaumeGomez:improve-message-search_is_some, r=llogiq

  Show description for a71211d
  bors

  committed
  a71211d

  Copy full SHA for a71211d

Commits on Jan 13, 2024

• Auto merge of rust-lang#118947 - Bryanskiy:delegStep1, r=petrochenkov,lcnr

  Show description for 5a45dbe
  bors

  committed
  5a45dbe

  Copy full SHA for 5a45dbe

• Remove special-case handling of vec.split_off(0)

  Zalathar

  committed
  a655558

  Copy full SHA for a655558

• from_over_into: suggest a correct conversion to ()

  samueltardieu

  committed
  e025356

  Copy full SHA for e025356

• lint on .map(|&x| x.clone())

  y21

  committed
  be5707c

  Copy full SHA for be5707c

Commits on Jan 14, 2024

• Add . to end of lint lists in configuration

  blyxyas

  committed
  2469784

  Copy full SHA for 2469784

• Change PublicallyExported -> PubliclyExported

  blyxyas

  committed
  44f5d96

  Copy full SHA for 44f5d96

• chore: negative test for multiple crate versions not working when name contains dashes

  kristof-mattei

  committed
  5769c21

  Copy full SHA for 5769c21

• fix: add fix for bug, fix test name

  kristof-mattei

  committed
  d975e26

  Copy full SHA for d975e26

• find function path references early in the lint pass

  y21

  committed
  0774489

  Copy full SHA for 0774489

• Correctly suggest std or core path depending if this is a no_std crate

  GuillaumeGomez

  committed
  1bcaf29

  Copy full SHA for 1bcaf29

• Update and add ui tests for core/std suggestions

  GuillaumeGomez

  committed
  40a45a4

  Copy full SHA for 40a45a4

• fix: don't allocate new string when not needed

  kristof-mattei

  committed
  5d06fbb

  Copy full SHA for 5d06fbb

• chore: add comments to explain reasoning

  kristof-mattei

  committed
  b1c52d5

  Copy full SHA for b1c52d5

• chore: remove unneeded into_iter

  kristof-mattei

  committed
  ea585ef

  Copy full SHA for ea585ef

• fix: crates are limited to ASCII values

  kristof-mattei

  committed
  e8ec998

  Copy full SHA for e8ec998

Commits on Jan 15, 2024

• Auto merge of rust-lang#12074 - ARandomDev99:12044-include-comments-while-checking-duplicate-code, r=Jarcho

  Show description for a9fa2f5
  bors

  committed
  a9fa2f5

  Copy full SHA for a9fa2f5

• Auto merge of rust-lang#12114 - talagrand:patch-1, r=Jarcho

  Show description for 37b8ae7
  bors

  committed
  37b8ae7

  Copy full SHA for 37b8ae7

• Auto merge of rust-lang#12141 - samueltardieu:issue-12138, r=Jarcho

  Show description for d6ff2d2
  bors

  committed
  d6ff2d2

  Copy full SHA for d6ff2d2

• Auto merge of rust-lang#12136 - y21:issue12135, r=Jarcho

  Show description for 692f53f
  bors

  committed
  692f53f

  Copy full SHA for 692f53f

• Try to improve wording and fix dead link in description of arc_with_non_send_sync lint.

  adamreichold

  committed
  33d8e47

  Copy full SHA for 33d8e47

• Add "OpenTelemetry" to default doc_valid_idents

  Show description for a16a850
  edmorley

  committed
  a16a850

  Copy full SHA for a16a850

• Add suspicious_open_options lint.

  Show description for 6c201db
  atwam

  committed
  6c201db

  Copy full SHA for 6c201db

• More helpful text, small style changes.

  atwam

  committed
  6fb471d

  Copy full SHA for 6fb471d

• PR Fixes

  atwam

  committed
  2ec8729

  Copy full SHA for 2ec8729

• Add suggestion/fix to suspicious_open_options

  Show description for 84588a8
  atwam

  committed
  84588a8

  Copy full SHA for 84588a8

• Fix conflicts

  Show description for 515fe65
  atwam

  committed
  515fe65

  Copy full SHA for 515fe65

• fix false positive in suspicious_open_options, make paths work

  

  y21

  authored and

  atwam

  committed
  f09cd88

  Copy full SHA for f09cd88

• Ensure callee_ids are body owners

  smoelius

  committed
  ad2a2ba

  Copy full SHA for ad2a2ba

• Auto merge of rust-lang#11926 - edmorley:update-default-doc_valid_idents, r=blyxyas

  Show description for 771a2a9
  bors

  committed
  771a2a9

  Copy full SHA for 771a2a9

• compiler: Lower fn call arg spans down to MIR

  Show description for 6a74a0e
  Enselic

  committed
  6a74a0e

  Copy full SHA for 6a74a0e

• Use std_or_core instead of doing check by hand every time

  GuillaumeGomez

  committed
  874f851

  Copy full SHA for 874f851

• Don't emit derive_partial_eq_without_eq lint if the type has the non_exhaustive attribute

  GuillaumeGomez

  committed
  a198904

  Copy full SHA for a198904

• Add non_exhaustive checks in derive_partial_eq_without_eq.rs ui test

  GuillaumeGomez

  committed
  136a582

  Copy full SHA for 136a582

Commits on Jan 16, 2024

• Auto merge of rust-lang#12149 - GuillaumeGomez:core-std-suggestions, r=llogiq

  Show description for ecb0311
  bors

  committed
  ecb0311

  Copy full SHA for ecb0311

• Correctly handle type relative in trait_duplication_in_bounds lint

  GuillaumeGomez

  committed
  169e2ab

  Copy full SHA for 169e2ab

• Update trait_duplication_in_bounds.rs ui test to add regression for #rust-lang#9961

  GuillaumeGomez

  committed
  7217c22

  Copy full SHA for 7217c22

• Deal with additional wrapping of async closure body in clippy

  compiler-errors

  committed
  f7376a0

  Copy full SHA for f7376a0

• Auto merge of rust-lang#11945 - adamreichold:fix-lint-comments, r=Alexendoo

  Show description for ca7b54b
  bors

  committed
  ca7b54b

  Copy full SHA for ca7b54b

• Auto merge of rust-lang#11608 - atwam:suspicious-open-options, r=y21

  Show description for 5f3a060
  bors

  committed
  5f3a060

  Copy full SHA for 5f3a060

Commits on Jan 17, 2024

• Add PatKind::Err

  ShE3py

  committed
  33e1e6f

  Copy full SHA for 33e1e6f

• Fix clippy

  oli-obk

  committed
  4488653

  Copy full SHA for 4488653

• Auto merge of rust-lang#11766 - dswij:issue-9274, r=blyxyas

  Show description for e27ebf2
  bors

  committed
  e27ebf2

  Copy full SHA for e27ebf2

• Auto merge of rust-lang#12155 - GuillaumeGomez:fix-9961, r=blyxyas

  Show description for 2067fe4
  bors

  committed
  2067fe4

  Copy full SHA for 2067fe4

• Auto merge of rust-lang#12146 - kristof-mattei:multiple-crate-versions-with-dashes, r=Manishearth

  Show description for bb2d497
  bors

  committed
  bb2d497

  Copy full SHA for bb2d497

Commits on Jan 18, 2024

• Rollup merge of rust-lang#119978 - compiler-errors:async-closure-captures, r=oli-obk

  Show description for cc629f0
  matthiaskrgr

  authored
  cc629f0

  Copy full SHA for cc629f0

• finally came up with some repro code

  J-ZhengLi

  committed
  9fe7c6a

  Copy full SHA for 9fe7c6a

• fix suggestion error with attr macros

  J-ZhengLi

  committed
  0e961cd

  Copy full SHA for 0e961cd

• Apply suggestions from code review

  Show description for 6a331e3
  

  smoelius

  and

  fee1-dead

  authored
  6a331e3

  Copy full SHA for 6a331e3

• Don't forget that the lifetime on hir types is 'tcx

  oli-obk

  committed
  7a1e7d7

  Copy full SHA for 7a1e7d7

• [default_numeric_fallback]: improve const context detection

  y21

  committed
  efd8daf

  Copy full SHA for efd8daf

• Auto merge of rust-lang#12168 - y21:issue12159, r=blyxyas

  Show description for b08ffee
  bors

  committed
  b08ffee

  Copy full SHA for b08ffee

• Auto merge of rust-lang#12167 - J-ZhengLi:issue12133, r=Alexendoo

  Show description for 4b3a9c0
  bors

  committed
  4b3a9c0

  Copy full SHA for 4b3a9c0

• Rollup merge of rust-lang#119869 - oli-obk:track_errors2, r=matthewjasper

  Show description for 21d719d
  matthiaskrgr

  authored
  21d719d

  Copy full SHA for 21d719d

• Update std::io::Error::downcast return type

  Show description for baa2cf5
  NobodyXu

  committed
  baa2cf5

  Copy full SHA for baa2cf5

Commits on Jan 19, 2024

• blocks_in_conditions: do not warn if condition comes from macro

  samueltardieu

  committed
  c6079a6

  Copy full SHA for c6079a6

• Auto merge of rust-lang#12173 - samueltardieu:issue-12162, r=Manishearth

  Show description for 6fd0258
  bors

  committed
  6fd0258

  Copy full SHA for 6fd0258

• Add new condition to avoid derived code trigger lint

  cocodery

  authored
  9661f9b

  Copy full SHA for 9661f9b

• Move the new check to the end of checks

  cocodery

  authored
  73d7ce6

  Copy full SHA for 73d7ce6

• Auto merge of rust-lang#12125 - cocodery:issue12045, r=xFrednet

  Show description for 989ce17
  bors

  committed
  989ce17

  Copy full SHA for 989ce17

• no_effect_underscore_binding: _ prefixed variables can be used

  Show description for 6267b6c
  samueltardieu

  committed
  6267b6c

  Copy full SHA for 6267b6c

Commits on Jan 20, 2024

• Pack the u128 in LitKind::Int

  cuviper

  committed
  eb42f3e

  Copy full SHA for eb42f3e

• Auto merge of rust-lang#12147 - y21:needless_pass_by_ref_mut_rm_visitor, r=llogiq

  Show description for 70573af
  bors

  committed
  70573af

  Copy full SHA for 70573af

• Improve wording for suggestion messages

  GuillaumeGomez

  committed
  49b0c3f

  Copy full SHA for 49b0c3f

• Update ui tests

  GuillaumeGomez

  committed
  38d9585

  Copy full SHA for 38d9585

• Move has_non_exhaustive_attr function into clippy_utils

  GuillaumeGomez

  committed
  fd6e752

  Copy full SHA for fd6e752

• Rollup merge of rust-lang#120000 - smoelius:fix-clippy, r=fee1-dead

  Show description for 8b0931a
  GuillaumeGomez

  authored
  8b0931a

  Copy full SHA for 8b0931a

• Auto merge of rust-lang#12144 - blyxyas:10283-postfix, r=llogiq

  Show description for fe3e682
  bors

  committed
  fe3e682

  Copy full SHA for fe3e682

Commits on Jan 21, 2024

• Auto merge of rust-lang#12172 - samueltardieu:issue-12166, r=Alexendoo

  Show description for 7386856
  bors

  committed
  7386856

  Copy full SHA for 7386856

• Auto merge of rust-lang#120100 - oli-obk:astconv_lifetimes, r=BoxyUwU

  Show description for 833cbd6
  bors

  committed
  833cbd6

  Copy full SHA for 833cbd6

• unused_io_amount captures Ok(_)s

  Show description for f73879e
  m-rph

  committed
  f73879e

  Copy full SHA for f73879e

• Auto merge of rust-lang#12005 - PartiallyTyped:11713, r=blyxyas

  Show description for 64d08a8
  bors

  committed
  64d08a8

  Copy full SHA for 64d08a8

• [multiple_crate_versions]: add a configuration option for allowed duplicate dependencies

  y21

  committed
  95a084f

  Copy full SHA for 95a084f

• Auto merge of rust-lang#12170 - GuillaumeGomez:improve-suggestions-wording, r=llogiq

  Show description for 99423e8
  bors

  committed
  99423e8

  Copy full SHA for 99423e8

• respect #[allow] attribute in single_call_fn lint

  y21

  committed
  ad4d90b

  Copy full SHA for ad4d90b

• Updating dependencies

  michaelciraci

  committed
  af76e3e

  Copy full SHA for af76e3e

Commits on Jan 22, 2024

• Rollup merge of rust-lang#119710 - Nilstrieb:let-_-=-oops, r=TaKO8Ki

  Show description for a417366
  matthiaskrgr

  authored
  a417366

  Copy full SHA for a417366

• Auto merge of rust-lang#120080 - cuviper:128-align-packed, r=nikic

  Show description for 93955e0
  bors

  committed
  93955e0

  Copy full SHA for 93955e0

• Auto merge of rust-lang#12153 - GuillaumeGomez:non-exhaustive, r=llogiq

  Show description for a8017ae
  bors

  committed
  a8017ae

  Copy full SHA for a8017ae

• Auto merge of rust-lang#12183 - y21:issue12182, r=dswij

  Show description for 0b6e7e2
  bors

  committed
  0b6e7e2

  Copy full SHA for 0b6e7e2

• Rename LintContext::struct_span_lint as LintContext::span_lint.

  nnethercote

  committed
  cf355c6

  Copy full SHA for cf355c6

• Rename TyCtxt::struct_span_lint_hir as TyCtxt::node_span_lint.

  nnethercote

  committed
  6b359b7

  Copy full SHA for 6b359b7

Commits on Jan 24, 2024

• Auto merge of rust-lang#12179 - y21:issue12176, r=dswij

  Show description for 76a75bf
  bors

  committed
  76a75bf

  Copy full SHA for 76a75bf

• suggest similar config option if one is found

  

  y21

  authored and

  blyxyas

  committed
  4780637

  Copy full SHA for 4780637

• Auto merge of rust-lang#12180 - y21:conf_lev_distance, r=blyxyas

  Show description for 900a5aa
  bors

  committed
  900a5aa

  Copy full SHA for 900a5aa

Commits on Jan 25, 2024

• Avoid useless checking in from_token_lit.

  Show description for 314dbc7
  nnethercote

  committed
  314dbc7

  Copy full SHA for 314dbc7

• Fix copy/paste error.

  Show description for 4b4bdb5
  nnethercote

  committed
  4b4bdb5

  Copy full SHA for 4b4bdb5

• Use from instead of into in unescaping code.

  Show description for ef1e222
  nnethercote

  committed
  ef1e222

  Copy full SHA for ef1e222

• Rework CStrUnit.

  Show description for a1c0721
  nnethercote

  committed
  a1c0721

  Copy full SHA for a1c0721

• Rename and invert sense of Mode predicates.

  Show description for 5e5aa6d
  nnethercote

  committed
  5e5aa6d

  Copy full SHA for 5e5aa6d

• Rename the unescaping functions.

  Show description for 86f371e
  nnethercote

  committed
  86f371e

  Copy full SHA for 86f371e

• Use unescape_unicode for raw C string literals.

  Show description for 6be2e56
  nnethercote

  committed
  6be2e56

  Copy full SHA for 6be2e56

• Don't fire OPAQUE_HIDDEN_INFERRED_BOUND on sized return of AFIT

  compiler-errors

  committed
  2aa7469

  Copy full SHA for 2aa7469

• privacy: Refactor top-level visiting in NamePrivacyVisitor

  petrochenkov

  committed
  15dbdab

  Copy full SHA for 15dbdab

• Auto merge of rust-lang#12184 - michaelciraci:merge-deps, r=llogiq

  Show description for 8a17125
  bors

  committed
  8a17125

  Copy full SHA for 8a17125

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  1534e08

  Copy full SHA for 1534e08

• Bump nightly version -> 2024-01-25

  flip1995

  committed
  c08c756

  Copy full SHA for c08c756

• Auto merge of rust-lang#12200 - flip1995:rustup, r=flip1995

  Show description for 66c29b9
  bors

  committed
  66c29b9

  Copy full SHA for 66c29b9

• Merge commit '66c29b973b3b10278bd39f4e26b08522a379c2c9' into clippy-subtree-update

  flip1995

  committed
  41e1231

  Copy full SHA for 41e1231

• Update Cargo.lock

  flip1995

  committed
  d7a0182

  Copy full SHA for d7a0182

Commits on Jan 26, 2024

• Rebase slice_group_by stabilization PR

  dtolnay

  committed
  97a720b

  Copy full SHA for 97a720b

• Clippy: Fix empty suggestion in from_over_into

  Show description for de8ccdb
  

  flip1995

  and

  y21

  committed
  de8ccdb

  Copy full SHA for de8ccdb

• Fix outdated comment on Box

  bjorn3

  committed
  1f994c7

  Copy full SHA for 1f994c7

• Rollup merge of rust-lang#117420 - Jules-Bertholet:internal-unstable-stmt-expr-attributes, r=petrochenkov

  Show description for 4808aa8
  matthiaskrgr

  authored
  4808aa8

  Copy full SHA for 4808aa8

• Rollup merge of rust-lang#117678 - niklasf:stabilize-slice_group_by, r=dtolnay

  Show description for a5b60c9
  matthiaskrgr

  authored
  a5b60c9

  Copy full SHA for a5b60c9

• Rollup merge of rust-lang#119917 - Zalathar:split-off, r=cuviper

  Show description for 772e80a
  matthiaskrgr

  authored
  772e80a

  Copy full SHA for 772e80a

• Rollup merge of rust-lang#120117 - NobodyXu:99262/update-api-and-doc, r=m-ou-se

  Show description for b09f232
  matthiaskrgr

  authored
  b09f232

  Copy full SHA for b09f232

• Rollup merge of rust-lang#120329 - nnethercote:3349-precursors, r=fee1-dead

  Show description for 5f1f617
  matthiaskrgr

  authored
  5f1f617

  Copy full SHA for 5f1f617

• Rollup merge of rust-lang#120339 - petrochenkov:nameprivisit, r=michaelwoerister

  Show description for c48c77e
  matthiaskrgr

  authored
  c48c77e

  Copy full SHA for c48c77e

• Rollup merge of rust-lang#120345 - flip1995:clippy-subtree-update, r=Manishearth

  Show description for 37b9022
  matthiaskrgr

  authored
  37b9022

  Copy full SHA for 37b9022

• Rollup merge of rust-lang#120360 - compiler-errors:afit-sized-lol, r=lcnr

  Show description for b4b4835
  matthiaskrgr

  authored
  b4b4835

  Copy full SHA for b4b4835

• Rollup merge of rust-lang#120372 - bjorn3:fix_outdated_comment, r=Nilstrieb

  Show description for d1c3dde
  matthiaskrgr

  authored
  d1c3dde

  Copy full SHA for d1c3dde