Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fetch HIR in inferred_outlives_of. #119261

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

cjgillot
Copy link
Contributor

Small simplification allowed by #119248

@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2023
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+

@bors
Copy link
Contributor

bors commented Dec 24, 2023

📌 Commit af5f7b3 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2023
@bors
Copy link
Contributor

bors commented Dec 24, 2023

⌛ Testing commit af5f7b3 with merge a120468...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2023
…r-errors

Do not fetch HIR in inferred_outlives_of.

Small simplification allowed by rust-lang#119248
@bors
Copy link
Contributor

bors commented Dec 25, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 25, 2023
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling getopts v0.2.21
[RUSTC-TIMING] unicode_width test:false 0.082
[RUSTC-TIMING] getopts test:false 1.654
   Compiling test v0.0.0 (/checkout/library/test)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Mon Dec 25 00:02:08 UTC 2023
  network time: Mon, 25 Dec 2023 00:02:08 GMT
##[endgroup]
##[endgroup]
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.

@cjgillot
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2023
@bors
Copy link
Contributor

bors commented Dec 25, 2023

⌛ Testing commit af5f7b3 with merge 1170479...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2023
…r-errors

Do not fetch HIR in inferred_outlives_of.

Small simplification allowed by rust-lang#119248
@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="8" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-valgrind/dst-dtor-1/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass-valgrind/dst-dtor-1/a", waiting for result
--- stderr -------------------------------
thread 'main' panicked at src/tools/remote-test-client/src/main.rs:310:9:
client.read_exact(&mut header) failed with Connection reset by peer (os error 104)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@bors
Copy link
Contributor

bors commented Dec 25, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 25, 2023
@cjgillot
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2023
@bors
Copy link
Contributor

bors commented Dec 25, 2023

⌛ Testing commit af5f7b3 with merge e4c626d...

@bors
Copy link
Contributor

bors commented Dec 25, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e4c626d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2023
@bors bors merged commit e4c626d into rust-lang:master Dec 25, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 25, 2023
@cjgillot cjgillot deleted the outlive-def-kind branch December 25, 2023 21:05
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e4c626d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.5%, -2.0%] 3
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.324s -> 669.724s (0.21%)
Artifact size: 312.49 MiB -> 312.56 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants