Add lint_duplicate_trait for duplicate specified traits in a trait object
#110991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Noratrieb
reviewed
Apr 29, 2023
|
|
||
| let mut bounds = (*bounds).to_owned(); | ||
|
|
||
| bounds.sort_unstable_by_key(|b| b.trait_ref.trait_def_id()); |
There was a problem hiding this comment.
DefIds are not stable across compilations and should not be used for sorting like here. Instead of what you're doing right now, you should use a FxHashSet and iterate through the bounds (in source order) and insert their def ids into the set. If a def id is already in the set, emit the lint.
There was a problem hiding this comment.
Will make that change. Out of curiosity, why does the fact they're unstable across compilations matter? The only aim of the sort is to group like DefIds together, which should still be valid given it is within one compilation right?
|
Shouldn't https://rust-lang.github.io/rust-clippy/master/#trait_duplication_in_bounds be extended instead? |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Thanks, have moved to rust-lang/rust-clippy#10727 |
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
May 9, 2023
Extend `trait_duplication_in_bounds` to cover trait objects
This PR extends `trait_duplication_in_bounds` to cover trait objects.
Currently,
```rs
fn foo(_a: &(dyn Any + Send + Send)) {}
```
generates no warnings. With this PR, it will complain about a duplicate trait and can remove it
Moved from rust-lang/rust#110991
changelog: [`trait_duplication_in_bounds`]: warn on duplicate trait object constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new lint,
lint_duplicate_traits, which warns when traits are duplicately specified, which currently produces no diagnostics.Related to #110961