-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include parent substs in substs
argument in nominal_obligations
when const param defaults exist
#106847
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
I have no idea how this code works ":) |
Wait...why? Can you explain a bit (definitely at least in a comment, also maybe here) why we need to skip nominal obligations? |
@jackh726 I found that we don't have to avoid |
InternalSubsts::identity_for_item(self.tcx, did) | ||
.into_iter() | ||
.chain(uv.substs), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs an explanation of what it's doing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, specifically I was asking about a comment that explains why you're chaining the identity parent substs with the (partially constructed) substs you have in uv.substs
.
It doesn't seem correct to me at first glance.
r? @BoxyUwU |
nominal_obligations
when const param defaults existsubsts
argument in nominal_obligations
when const param defaults exist
23c6ce5
to
78d2dea
Compare
I don't feel super comfortable merging more hacks to make
|
Fixes #106994