Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rustdoc json tests #100678

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Improve rustdoc json tests #100678

merged 2 commits into from
Aug 23, 2022

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-json Area: Rustdoc JSON backend labels Aug 17, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid requested changes Aug 17, 2022
View reviewed changes
@aDotInTheVoid
Copy link
Member

FYI, I don't have r+ privileges, so can't approve this PR.

r? @CraftSpider

@GuillaumeGomez
Copy link
Member Author

I know, but if it looks good to you, I can approve for you, so it's fine. ;)

@GuillaumeGomez GuillaumeGomez force-pushed the improve-rustdoc-json-tests branch from 329dca9 to 6f2b5e4 Compare August 17, 2022 15:02
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 17, 2022 •
edited
Loading

Applied your suggestions (and rebased on master to fix CI).

aDotInTheVoid
aDotInTheVoid requested changes Aug 17, 2022
View reviewed changes
@GuillaumeGomez GuillaumeGomez force-pushed the improve-rustdoc-json-tests branch from 6f2b5e4 to c71550e Compare August 17, 2022 15:57
@GuillaumeGomez
Copy link
Member Author

Applied suggestions bis repetita. :)

aDotInTheVoid
aDotInTheVoid approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@aDotInTheVoid aDotInTheVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the improve-rustdoc-json-tests branch from c71550e to 12102f0 Compare August 17, 2022 16:35
@bors
Copy link
Contributor

bors commented Aug 17, 2022

☔ The latest upstream changes (presumably #100677) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 17, 2022
@GuillaumeGomez GuillaumeGomez force-pushed the improve-rustdoc-json-tests branch from 12102f0 to d3d9e22 Compare August 18, 2022 09:00
@GuillaumeGomez
Copy link
Member Author

@bors: r=aDotInTheVoid rollup=never

@bors
Copy link
Contributor

bors commented Aug 18, 2022

📌 Commit d3d9e22 has been approved by aDotInTheVoid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2022
@bors
Copy link
Contributor

bors commented Aug 23, 2022

⌛ Testing commit d3d9e22 with merge 7e3e8a8...

@bors
Copy link
Contributor

bors commented Aug 23, 2022

☀️ Test successful - checks-actions
Approved by: aDotInTheVoid
Pushing 7e3e8a8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2022
@bors bors merged commit 7e3e8a8 into rust-lang:master Aug 23, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 23, 2022
@bors bors mentioned this pull request Aug 23, 2022
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7e3e8a8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.9% [-1.9%, -1.9%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 -2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [-2.0%, 2.4%] 2

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@GuillaumeGomez GuillaumeGomez deleted the improve-rustdoc-json-tests branch August 23, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aDotInTheVoid aDotInTheVoid aDotInTheVoid approved these changes

Assignees
No one assigned
Labels
A-rustdoc-json Area: Rustdoc JSON backend C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

JsonDocCk: Automaticly infer file name
6 participants
@GuillaumeGomez @rust-log-analyzer @aDotInTheVoid @bors @rust-timer @rustbot