-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When running tests in parallel, test runner does not display colors #782
Comments
I don't think 828d067 is correct, for reasons I left on the commit. |
We could just hunt down all the tests that log to error or print to stdout and make them log to debug instead, then call it a day. Seeing the pretty colors is super nice. Probably 828d067 should still be reverted though, unless there's something about it I'm missing. |
Sorry. I'll revert the commits. |
Added far-future milestone |
Bug triage. Far-future still seems right. |
Triage bump. There's been no change. |
Triage bump. Still relevant. |
I believe the test runner captures stdio now. It should be safe to print colors carefully. |
The output of individual tests can be captured now so it's safe to use colorized output even when running tests in parallel. Closes rust-lang#782.
The output of individual tests can be captured now so it's safe to use colorized output even when running tests in parallel. Closes #782.
The output of individual tests can be captured now so it's safe to use colorized output even when running tests in parallel. Closes rust-lang#782.
Add support for aarch64-unknown-linux-musl This adds support for aarch64-unknown-linux-musl as requested in rust-lang#44779 by @alexcrichton The new file `ci/docker/aarch64-unknown-linux-musl/Dockerfile` essentially merges the aarch64-unknown-linux-gnu and x86_64-unknown-linux-musl Dockerfiles. The bigger changes are under `src/unix/notbsd/linux/`, though they're fairly superficial: Previously, some constants could be shared between all 64-bit musl triples, but aarch64 differs, so a number of things were moved from `musl/b64/mod.rs` to specific arches: `musl/b64/powerpc64.rs` and `musl/b64/x86_64.rs`, with the aarch64-specific differences being added to `musl/b64/aarch64.rs`. Similarly, some constants moved from `musl/mod.rs` to lower levels: `musl/b32/mod.rs`, `musl/b64/powerpc64.rs`, and `musl/b64/x86_64.rs`, with the aarch64-specific differences added to `musl/b64/aarch64.rs`. Finally, some things that were true of all Linux builds moved from `mod.rs` into lower levels: `mips/mod.rs`, `other/mod.rs`, `musl/b32/mod.rs`, `musl/b64/powerpc64.rs`, and `musl/b64/x86_64.rs`, with the aarch64-specific differences added to `musl/b64/aarch64.rs`. Testing: All linux-based triples under `ci/docker` were run through `ci/run-docker.sh` successfully, which checks that the size and alignment of definitions match for each triple, among other tests. (The local build of rust from rust-lang#44779 was set for the aarch64-unknown-linux-musl build.) I also confirmed that it has "good style!" according to `ci/style.rs`.
Size fo empty structs in C is zero byte.
The control characters seem to cause strange artifacts so colors are disabled.
The text was updated successfully, but these errors were encountered: