Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running tests in parallel, test runner does not display colors #782

Closed
brson opened this issue Jul 29, 2011 · 8 comments · Fixed by #25805
Closed

When running tests in parallel, test runner does not display colors #782

brson opened this issue Jul 29, 2011 · 8 comments · Fixed by #25805
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jul 29, 2011

The control characters seem to cause strange artifacts so colors are disabled.

lht added a commit that referenced this issue Apr 12, 2012
@lht lht closed this as completed in 7b3cb05 Apr 12, 2012
@brson brson reopened this Apr 12, 2012
@brson
Copy link
Contributor Author

brson commented Apr 12, 2012

I don't think 828d067 is correct, for reasons I left on the commit.

@brson
Copy link
Contributor Author

brson commented Apr 12, 2012

We could just hunt down all the tests that log to error or print to stdout and make them log to debug instead, then call it a day. Seeing the pretty colors is super nice. Probably 828d067 should still be reverted though, unless there's something about it I'm missing.

@lht
Copy link
Contributor

lht commented Apr 13, 2012

Sorry. I'll revert the commits.

@catamorphism
Copy link
Contributor

Added far-future milestone

@catamorphism
Copy link
Contributor

Bug triage. Far-future still seems right.

@metajack
Copy link
Contributor

Triage bump. There's been no change.

@treeman
Copy link
Contributor

treeman commented Sep 15, 2014

Triage bump. Still relevant.

@brson
Copy link
Contributor Author

brson commented Jan 13, 2015

I believe the test runner captures stdio now. It should be safe to print colors carefully.

@brson brson added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Jan 13, 2015
jooert added a commit to jooert/rust that referenced this issue May 26, 2015
The output of individual tests can be captured now so it's safe to use
colorized output even when running tests in parallel. Closes rust-lang#782.
bors added a commit that referenced this issue May 28, 2015
The output of individual tests can be captured now so it's safe to use
colorized output even when running tests in parallel. Closes #782.
XMPPwocky pushed a commit to XMPPwocky/rust that referenced this issue May 29, 2015
The output of individual tests can be captured now so it's safe to use
colorized output even when running tests in parallel. Closes rust-lang#782.
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
Add support for aarch64-unknown-linux-musl

This adds support for aarch64-unknown-linux-musl as requested in rust-lang#44779 by @alexcrichton

The new file `ci/docker/aarch64-unknown-linux-musl/Dockerfile` essentially merges the aarch64-unknown-linux-gnu and x86_64-unknown-linux-musl Dockerfiles.

The bigger changes are under `src/unix/notbsd/linux/`, though they're fairly superficial:

Previously, some constants could be shared between all 64-bit musl triples, but aarch64 differs, so a number of things were moved from `musl/b64/mod.rs` to specific arches: `musl/b64/powerpc64.rs` and `musl/b64/x86_64.rs`, with the aarch64-specific differences being added to `musl/b64/aarch64.rs`.

Similarly, some constants moved from `musl/mod.rs` to lower levels: `musl/b32/mod.rs`, `musl/b64/powerpc64.rs`, and `musl/b64/x86_64.rs`, with the aarch64-specific differences added to `musl/b64/aarch64.rs`.

Finally, some things that were true of all Linux builds moved from `mod.rs` into lower levels: `mips/mod.rs`, `other/mod.rs`, `musl/b32/mod.rs`, `musl/b64/powerpc64.rs`, and `musl/b64/x86_64.rs`, with the aarch64-specific differences added to `musl/b64/aarch64.rs`.

Testing:

All linux-based triples under `ci/docker` were run through `ci/run-docker.sh` successfully, which checks that the size and alignment of definitions match for each triple, among other tests.  (The local build of rust from rust-lang#44779 was set for the aarch64-unknown-linux-musl build.)

I also confirmed that it has "good style!" according to `ci/style.rs`.
pdietl pushed a commit to pdietl/rust that referenced this issue Apr 23, 2020
Size fo empty structs in C is zero byte.
bors pushed a commit to rust-lang-ci/rust that referenced this issue Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants