Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifetime scope note messages have off-by-one column numbers. #41938

Closed
eddyb opened this issue May 12, 2017 · 0 comments
Closed

Lifetime scope note messages have off-by-one column numbers. #41938

eddyb opened this issue May 12, 2017 · 0 comments

Comments

@eddyb
Copy link
Member

eddyb commented May 12, 2017

The explain_span function used for them doesn't convert lo.col to be 1-based.

Noticed because in #41914 some messages ended up looking like this:

note: the anonymous lifetime #2 defined on the function body at 15:0...
@fhartwig fhartwig mentioned this issue May 17, 2017
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 20, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42062 - fhartwig:fix-off-by-one-span, r=nik…
2945642 
…omatsakis

Fix off-by-one error in column number in `explain_span`.

Fixes rust-lang#41938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eddyb