Lint range_plus_one and range_minus_one (closes #329) #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasf
force-pushed
the
range-plus-minus-one
branch
from
7d66b9d to
fb2c777
Compare
|
Cool! Can you add some tests? We should also make this allow by default, since inclusive range syntax isn't stable yet |
niklasf
force-pushed
the
range-plus-minus-one
branch
from
fb2c777 to
9cceb58
Compare
|
I've added some examples to Update: I retrieved the normalized stderr from Travis. Still curious what would have been the right way to get it. |
niklasf
force-pushed
the
range-plus-minus-one
branch
from
9cceb58 to
16781a1
Compare
|
You need to run cargo test first before running the script without any arguments |
|
Thanks for the new lints. We'll turn it to warn by default once the syntax is stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to implement the idea from #329.