Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy provides non-working links with namespaced lint names for more information #3132

Closed
Nemo157 opened this issue Sep 5, 2018 · 1 comment
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@Nemo157
Copy link
Member

Nemo157 commented Sep 5, 2018

error: mutable borrow from immutable input(s)
   --> examples/apps/hello/src/lib.rs:124:47
    |
124 |         unsafe fn get_mut_unchecked(&self) -> &mut T {
    |                                               ^^^^^^
    |
    = note: #[deny(clippy::mut_from_ref)] on by default
note: immutable borrow here
   --> examples/apps/hello/src/lib.rs:124:37
    |
124 |         unsafe fn get_mut_unchecked(&self) -> &mut T {
    |                                     ^^^^^
    = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#clippy::mut_from_ref

note the url at the end, going here does not show anything, you must remove the clippy:: namespacing.

My suggestion would be to keep the namespacing and update the webpage to strip it when searching.

@phansch phansch added the C-bug Category: Clippy is not doing the correct thing label Sep 5, 2018
@phansch
Copy link
Member

phansch commented Sep 5, 2018

Thanks for the report! We should really have a linkchecker on CI that checks the links of every lint, as this happened before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Development

No branches or pull requests

2 participants