Implement format hook #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Dec 9, 2018
crates/tools/src/lib.rs
Outdated
| cargo format | ||
| for path in $( git diff --name-only --cached ); do | ||
| git update-index --add $path | ||
| done"# |
There was a problem hiding this comment.
Hm, let's make a hook itself a rust program, so that it doesn't depend on a particular shell and works on windows?
What I have in mind is to have a src/bin/pre-commit.rs program which basically runs this function.
Then the install-format-hook would run cargo build --release --package tools --bin pre-commit and copy the binary from target/release to ./git/hooks
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 9, 2018
271: Implement format hook r=matklad a=DJMcNab Tentatively: fixes #155. However, this does add all changes in staged files, which might not be desirable. However, I think we can't solve that without explicit support in rustfmt for it, so it should be fine. Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentatively: fixes #155.
However, this does add all changes in staged files, which might not be desirable. However, I think we can't solve that without explicit support in rustfmt for it, so it should be fine.