Put the search bar into an HTML form #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also causes the browser to show the form submission history pop-up, which seems good, and causes the browser to submit/reload when you hit enter, which seems fine. LGTM |
|
It probably makes sense to prevent the form submission behavior, since it causes an unnecessary reload. |
This enables "Add a keyword for this search" in the contex menu for the search field, in Firefox and other browsers.
Done. Note, this is also what rustdoc does for its search form. |
|
I just tried this out locally, looks good to me 👍 |
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
This enables "Add a keyword for this search" in the contex menu for the search field, in Firefox and other browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables "Add a keyword for this search" in the contex menu for the
search field, in Firefox and other browsers.