Fix unnecessary search path warning on macOS #235
Merged
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linker on macOS warns on unused search paths, and concretely, when compiling
zlib-ng
via this crate, it warns with:This warning has previously been hidden away, but
rustc
wants to surface them by default at some point.So let's avoid the warning by setting
CMAKE_INSTALL_LIBDIR
explicitly, and then only passing a single search path to the linker.Can be tested on macOS with:
$ RUSTFLAGS="-Wlinker-messages" cargo +nightly test --no-default-features --features zlib-ng