Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openbsd: add devname(3) #4285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

openbsd: add devname(3) #4285

wants to merge 1 commit into from

Conversation

tobhe
Copy link

@tobhe tobhe commented Feb 25, 2025

Description

I'm planning to add OpenBSD support to the drm crate, for that I need devname(3) to replace devname_r which is used on FreeBSD but not available on OpenBSD.

Sources

https://man.openbsd.org/devname.3
https://github.com/openbsd/src/blob/master/include/stdlib.h#L283
https://github.com/openbsd/src/blob/master/lib/libc/gen/devname.c#L73

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2025

Some changes occurred in OpenBSD module

cc @semarie

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this may be available on all the BSDs we support; OpenBSD (your link), NetBSD https://man.netbsd.org/devname.3, FreeBSD https://man.freebsd.org/cgi/man.cgi?query=devname&sektion=3&n=1, and Apple https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/devname.3.html. Would you be able to try moving this definition to unix/bsd/mod.rs so they all get it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants