Classify FIXMEs - 6 #4234
Classify FIXMEs - 6 #4234
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
libc-test/build.rs
Outdated
| @@ -680,7 +680,7 @@ fn test_windows(target: &str) { | |||
| // Just pass all these through, no need for a "struct" prefix | |||
| "FILE" | "DIR" | "Dl_info" => ty.to_string(), | |||
|
|
|||
| // FIXME: these don't exist: | |||
| // FIXME(ctest): these don't exist: | |||
There was a problem hiding this comment.
// FIXME(ctest) should be for things that fail due to bugs in ctest itself (i.e. need to be fixed in the ctest crate), rather than things that fail while running ctest. So this could probably just get the relevant platform, FIXME(windows).
Couple instances of ctest here but the rest lgtm 👍 . Please squash and rebase after updating those.
There was a problem hiding this comment.
ok sounds good. This should be resolved now.
There was a problem hiding this comment.
It looks like there is one more, // FIXME(ctest): The size and alignment of this struct are incorrect (line 725). The rest lgtm 👍
tgross35
added
the
stable-nominated
|
@lvllvl could you change the last |
lvllvl
force-pushed
the
4117-part-6
branch
3 times, most recently
from
40b5d60 to
835192e
Compare
Hi, yes just made the updates. If there's any other change please let me know. I think there's 2 other PRs that I need to wrap up. Will try and address those tomorrow. |
Description
Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI