Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux/android: deprecate obsolete kernel module syscalls #4228

Merged
merged 1 commit into from
Jan 10, 2025
Merged

linux/android: deprecate obsolete kernel module syscalls #4228

merged 1 commit into from
Jan 10, 2025

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Jan 5, 2025

they were functional up 2.6.

create_module query_module get_kernel_syms

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2025

Some changes occurred in the Android module

cc @maurer

maurer
maurer approved these changes Jan 6, 2025
View reviewed changes
Copy link

@maurer maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from Android PoV - a quick spot check shows these are in fact all syscalls removed in 2.6, and even the earliest Android kernels were past 2.6.

@tgross35 tgross35 added this pull request to the merge queue Jan 10, 2025
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jan 10, 2025
@tgross35 tgross35 changed the title linux/android proposal to deprecate kernel modules syscalls. linux/android: deprecate nonfunctional kernel modules syscalls Jan 10, 2025
@tgross35 tgross35 changed the title linux/android: deprecate nonfunctional kernel modules syscalls linux/android: deprecate nonfunctional kernel module syscalls Jan 10, 2025
@tgross35 tgross35 changed the title linux/android: deprecate nonfunctional kernel module syscalls linux/android: deprecate obsolete kernel module syscalls Jan 10, 2025
Merged via the queue into rust-lang:main with commit 94d0ee2 Jan 10, 2025
45 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Feb 14, 2025
@devnexen @tgross35
linux/android proposal to deprecate kernel modules syscalls.
ab5bbae 
they were functional up 2.6.

[create_module](https://man7.org/linux/man-pages/man2/create_module.2.html)
[query_module](https://man7.org/linux/man-pages/man2/query_module.2.html)
[get_kernel_syms](https://man7.org/linux/man-pages/man2/get_kernel_syms.2.html)

(backport <rust-lang#4228>)
(cherry picked from commit e84fc94)
@tgross35 tgross35 mentioned this pull request Feb 14, 2025
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurer maurer maurer approved these changes

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
O-android O-gnu O-linux O-mips O-musl O-sparc O-unix O-x86 S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devnexen @rustbot @maurer @tgross35