-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Linux system call constants #2904
Conversation
This adds the latest Linux system call constants based on the Kernel's system call table: https://github.com/torvalds/linux/blob/master/arch/x86/entry/syscalls/syscall_64.tbl
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
I have no idea how the process for adding new system call constants generally works, but I saw that #2114 seemingly just added all the stuff manually and decided to do the same. I personally need the I've only checked the system call table for x86_64 and extrapolated all the other architectures from there. It seems like for existing syscalls they're mostly the same with some constant offset, so I've tried to just keep that pattern going. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're sure they are valid on each arch and aren't supposed to be changed in the long term, I think it's totally fine.
Thanks for contributing!
@bors r+ |
Add new Linux system call constants This adds the latest Linux system call constants based on the Kernel's system call table: https://github.com/torvalds/linux/blob/master/arch/x86/entry/syscalls/syscall_64.tbl
💔 Test failed - checks-actions |
The build failed on a component download on Windows, so I don't think it's related to this PR. |
@bors retry |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
This adds the latest Linux system call constants based on the Kernel's system call table:
https://github.com/torvalds/linux/blob/master/arch/x86/entry/syscalls/syscall_64.tbl