fcntl F_DUPFD_CLOEXEC has different values on Solaris and Illumos #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
jclulow
suggested changes
Sep 5, 2022
src/unix/solarish/illumos.rs
Outdated
| @@ -42,6 +42,9 @@ pub const F_OFD_SETLKW: ::c_int = 49; | |||
| pub const F_FLOCK: ::c_int = 53; | |||
| pub const F_FLOCKW: ::c_int = 54; | |||
|
|
|||
| // fcntl F_DUPFD_CLOEXEC has different values on Solaris and Illumos | |||
There was a problem hiding this comment.
Suggested change
| // fcntl F_DUPFD_CLOEXEC has different values on Solaris and Illumos |
I would remove the comments. The separate file structure already denotes different constants for illumos and Solaris, and the file would be full of comments like this if we noted every difference.
jclulow
approved these changes
Sep 5, 2022
JohnTitor
approved these changes
Sep 10, 2022
|
@bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.