Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pthread scheduling functions for WASM #2754

Open
iddm opened this issue Apr 12, 2022 · 2 comments
Open

Support pthread scheduling functions for WASM #2754

iddm opened this issue Apr 12, 2022 · 2 comments
Labels
C-API-request Category: API request E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Milestone

Comments

@iddm
Copy link
Contributor

iddm commented Apr 12, 2022

According to emscripten, the pthread is supported.
I quickly went through the documentation and found many things out of it implemented but also a few things which aren't there, for example:

  • pthread_setschedparam
  • pthread_getschedparam

And a few others.

Is there any reason those aren't added? Maybe these, in particular, aren't supported for wasm and emscripten? Can I add those if those are supported?
P.S. Asking mainly due to the support of wasm has been asked for in the thread-priority crate.

@iddm iddm added the C-API-request Category: API request label Apr 12, 2022
@iddm
Copy link
Contributor Author

iddm commented Apr 20, 2022

Okay, waiting for 8 days seems enough, I'll add those. This is their implementation when emscripten is built with posix threads support: https://github.com/emscripten-core/emscripten/blob/e05e72d9c49fe15578e73934ce525a894d1b712a/system/lib/libc/musl/include/pthread.h#L100

bors added a commit that referenced this issue Apr 20, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Apr 22, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Apr 22, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Apr 23, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Apr 23, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Apr 28, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue May 5, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue May 5, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue May 9, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue May 18, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue May 22, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue May 23, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue May 24, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Jun 9, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Jun 9, 2022
…, r=Amanieu

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Sep 13, 2022
…, r=<try>

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Sep 13, 2022
…, r=<try>

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Sep 13, 2022
…, r=<try>

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Sep 13, 2022
…, r=<try>

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
bors added a commit that referenced this issue Sep 13, 2022
…, r=<try>

Add pthread_[s,g]etschedparam to emscripten.

Closes #2754

The functions are available in emscripten when built with the posix threads support.
@tgross35 tgross35 added the E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. label Aug 29, 2024
@tgross35 tgross35 added this to the 1.x milestone Aug 29, 2024
@tgross35
Copy link
Contributor

Help is still welcome for this from anyone who is interested, labeling hard based on #2764. Maybe our newer emscripten toolchain will do better here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-API-request Category: API request E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants