Skip to content

Commit

Permalink
Auto merge of #3127 - JohnTitor:rm-semver-check, r=JohnTitor
Browse files Browse the repository at this point in the history
Drop semver check job on CI

This hasn't run for a while and the crate no longer works unless a whole rewriting happens (due to the save analysis removal).
We sometimes allow breaking changes if an item doesn't work in all the use cases (i.e. we can imply there's no real user). For these reasons, I think it's fine to remove these jobs.
  • Loading branch information
bors committed Mar 1, 2023
2 parents f536356 + 204aee3 commit 02d27a4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 102 deletions.
26 changes: 0 additions & 26 deletions .github/workflows/bors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -317,32 +317,6 @@ jobs:
run: LIBC_CI=1 TOOLCHAIN=${{ matrix.toolchain }} WIN_TARGET=${{ matrix.target }} sh ./ci/build.sh
shell: bash

semver_linux:
if: ${{ false }} # This is currently broken
name: Semver Linux
runs-on: ubuntu-22.04
continue-on-error: true
steps:
- uses: actions/checkout@v3
- name: Setup Rust toolchain
# Should update the semverver revision in semver.sh if we touch nightly ver.
run: TOOLCHAIN=nightly-2022-05-23 sh ./ci/install-rust.sh
- name: Check breaking changes
run: sh ci/semver.sh linux

semver_macos:
if: ${{ false }} # This is currently broken
name: Semver macOS
runs-on: macos-12
continue-on-error: true
steps:
- uses: actions/checkout@v3
- name: Setup Rust toolchain
# Pin nightly version to make semverver compilable.
run: TOOLCHAIN=nightly-2022-05-23 sh ./ci/install-rust.sh
- name: Check breaking changes
run: sh ci/semver.sh macos

docs:
permissions:
actions: write # to cancel workflows (rust-lang/simpleinfra/github-actions/cancel-outdated-builds)
Expand Down
75 changes: 0 additions & 75 deletions ci/semver.sh

This file was deleted.

2 changes: 1 addition & 1 deletion libc-test/semver/linux-gnu.txt
Original file line number Diff line number Diff line change
Expand Up @@ -669,4 +669,4 @@ strftime
strptime
dirname
posix_basename
gnu_basename
gnu_basename

0 comments on commit 02d27a4

Please sign in to comment.