feat: reduce CrcReader::sum calls in GzEncoder::read_footer #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces calls to CrcReader::sum (which clones 16 bytes).
Replaces manual shifting with rust-provided
to_le_bytes
.Moved explicit reference from declaration to usage.
I think this would technically be a perf improvement, but there is no real world difference in it at all (godbolt here).