Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #449

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Fix CI #449

merged 1 commit into from
Feb 9, 2025

Conversation

Byron
Copy link
Member

@Byron Byron commented Feb 8, 2025

CI is failing and in such a way that doesn't reproduce locally,
even when using Ubuntu.

Maybe it's related an out-of-memory situation?

Ideas

  • bisect using CI - when did it start failing?
  • bisect tests by inclusion, exclusion
    • it's not related to 'big' roundtrips
  • let's just get it to work by not testing failing platforms (cloudflare only).

@Byron Byron force-pushed the try-fix-ci branch 2 times, most recently from b885a55 to 08642ec Compare February 8, 2025 19:15
On MacOS it works, and it's unclear why that happens.
For now just give up and make it work.
@Byron Byron marked this pull request as ready for review February 8, 2025 20:31
Copy link
Member Author

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work, nice!

@Byron Byron enabled auto-merge February 8, 2025 20:31
@Byron Byron requested a review from jongiddy February 8, 2025 20:32
@Byron Byron changed the title Try to fix CI Fix CI Feb 9, 2025
@Byron Byron requested a review from joshtriplett February 9, 2025 08:13
@joshtriplett
Copy link
Member

Seems reasonable to me to fix CI first before starting to debug it.

I personally would treat the cloudflare-zlib support as being in maintenance mode at the moment.

@Byron Byron merged commit c63acc8 into main Feb 9, 2025
27 checks passed
@Byron Byron deleted the try-fix-ci branch February 9, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants