Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for unioning bigger sets if necessary, but also doesn't necessarily change the storage size because it may still downsize to an u32 in from_index.
This shouldn't change anything to perf if the caller still uses u32 in their UnifyKey, considering that converting from usize to u32 was already done just before these function calls, and now it will be done just after, and they will likely be inlined.
The only place I can see where this may have implications is on
rank
, which may need to be made bigger as well... but it looks like the max rank is actually logarithmic in the number of nodes if we merge favoring min rank so it's unlikely to be necessary.