Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Removed the search index updater #804

Merged
merged 1 commit into from
Jun 3, 2020
Merged

[Refactor] Removed the search index updater #804

merged 1 commit into from
Jun 3, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Jun 2, 2020

  • Removed the update-search-index command and service
  • Updating is now relegated to add_package_into_database, so changes are reflected instantly
  • Removed the unneeded content and versions columns from the crates table
  • Made CrateDetails::new() use strings for getting query rows instead of indices for readability

Unanswered Questions:

@Kixiron Kixiron requested a review from Nemo157 June 2, 2020 17:05
@Kixiron Kixiron force-pushed the update-refactor branch from 548aff4 to 20a806b Compare June 2, 2020 17:16
jyn514
jyn514 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyn514
Copy link
Member

jyn514 commented Jun 3, 2020

CrateDetails.rustdoc gets its data from crates.description_long, maybe a rename is in order?

Sounds reasonable, I think rustdoc should be changed to description_long. Let's do that in a separate PR.

@jyn514 jyn514 merged commit d4089ba into rust-lang:master Jun 3, 2020
@Kixiron
Copy link
Member Author

Kixiron commented Jun 3, 2020

I think that when tera goes through we can actually get away with just storing the entire description and just truncating through templates

@Kixiron Kixiron deleted the update-refactor branch June 3, 2020 02:24
@Kixiron Kixiron mentioned this pull request Jun 6, 2020
Closed
@jyn514 jyn514 mentioned this pull request Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

@Nemo157 Nemo157 Awaiting requested review from Nemo157

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kixiron @jyn514