Move request logging near the top of the middleware stack #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By converting to a regular `Middleware` (instead of `AroundMiddleware`), the logging can now sit near the top of the middleware stack. Previously logging occurred at the top of the around stack, which sits under the layers added via `add()`. This change ensures that middleware sitting below the request logger in the stack are able to add logging metadata in a call to `after()`.
JohnTitor
approved these changes
Apr 2, 2020
|
Looks good! @bors r+ |
|
📌 Commit dc6f424 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By converting to a regular
Middleware(instead ofAroundMiddleware),the logging can now sit near the top of the middleware stack.
Previously logging occurred at the top of the around stack, which sits
under the layers added via
add().This change ensures that middleware sitting below the request logger
in the stack are able to add logging metadata in a call to
after().r? @JohnTitor