Implement divsf3 and divdf3 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #205) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thanks! Just to confirm, this is all basically ported from the C version, right? |
|
Yep it is pretty much copied line by line from C version. I had to get a little creative due to the type system and the C versions liberal use of casting between types and unsigned number negations, but I tried to make each line have the same function as in the C version. |
|
Ok sounds great, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has two different functions for 32 and 64 bit as the 64 bit version but has some differences in how it does the calculations. Both are integrated into the testing system and pass all tests.