-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Iterator::nth for Combinations #329
Conversation
I have rebased this on |
Thanks! I'll take a look at this soon. |
@fyrchik I've filed a PR adding a quickcheck test on your feature branch: fyrchik#1 That test case is finding differences between the output of your specialized The specialized version of |
I have reimplemented this and got rid of binomial coefficients. |
Thanks! Could you resolve the merge conflict? Also, note that the behavior of |
I have rebased on master. |
Hi @fyrchik, EDIT: Well, I see all your repositories are archived, I'm closing this. |
Hello!
I have implemented
nth
method forCombinations
iterator.Closes #301 .
Let me know, what do you think. Other changes in tests are due to
rustfmt
.