Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Deserialize on ImportDescriptors #273

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Derive Deserialize on ImportDescriptors #273

merged 2 commits into from
Jan 4, 2023

Conversation

casey
Copy link
Contributor

@casey casey commented Jan 3, 2023

We wound up needing Deserialize on ImportDescriptors for our mock Bitcoin Core RPC server.

@casey casey force-pushed the deserialize-import-descriptors branch from 9c763a3 to df2ab99 Compare January 3, 2023 21:59
apoelstra
apoelstra approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK df2ab99

@apoelstra
Copy link
Member

LGTM. Note that this is actually two changes in one -- it adds Deserialize and also it removes a &'a str, replacing it with a String.

@apoelstra apoelstra merged commit 8cccc5f into rust-bitcoin:master Jan 4, 2023
@casey casey deleted the deserialize-import-descriptors branch January 4, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @apoelstra