json: add Other variant to SoftforkType #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-bitcoin#267. Without this variant, a call to `client.get_blockchain_info()` likely fails on some versions of bitcoind where other types of softfork deployments were active.
benma
changed the title
|
Lol, LGTM. If this were a field we expected to be used in the future I'd complain and say that the new variant should contain more information so that we can round-trip it. But I'll accept this for the sake of avoiding a parse error in old versions of Core (or litecoin). |
apoelstra
approved these changes
Dec 20, 2022
|
Will let @tcharding also chime in before merging. |
I did it this way with the same reasoning 😄 Adding more info in this variant would have added quite a lot of boilerplate code and effort. |
tcharding
approved these changes
Dec 20, 2022
apoelstra
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267. Without this variant, a call to
client.get_blockchain_info()likely fails on some versions ofbitcoind where other types of softfork deployments were active.