-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support non-ASCII identifiers #813
Conversation
Hi John-John @udoprog, The |
Hi! This looks great, thanks for the PR! Please move the test into A cargo feature flag is not appropriate since it transitively changes the behavior of anyone using Rune if one dependency activates it. In my view we should just adopt this for 0.14. If we do think it's an appropriate optional feature, add a an |
The feature `non_ascii_idents` gives Rune feature parity with Rust in supporting Unicode identifiers. Refer to: rust-lang/rfcs#2457
2bb699e
to
6a218c8
Compare
Thanks for the suggestions. I'll update the PR later. |
I was worried about introducing a dependency for a rarely needed feature. Otherwise I don't think users will ever want to disable it since it's a compatible change. Also the performance report from |
Enable non-ASCII identifiers by default.
The dependency is not a problem so please go ahead. |
Thank you! |
Support Unicode identifiers.
Refer to the similar language feature in Rust:
rust-lang/rfcs#2457