Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add high-performance wrapper type. #25

Closed
ruipin opened this issue Feb 17, 2021 · 1 comment
Closed

Add high-performance wrapper type. #25

ruipin opened this issue Feb 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ruipin
Copy link
Owner

ruipin commented Feb 17, 2021

While negligible in most cases, libWrapper will add some overhead to wrapper calls compared to traditional wrappers.

In some cases, e.g. testWall, methods get called thousands of times in a loop, meaning that said performance hit actually becomes noticeable.

For these cases, it could make sense to add a wrapper type which does static dispatch. This type would avoid having to set up the libWrapper context, and forgo most of the libWrapper safeties, keeping only basic conflict checking and module prioritisation. Everything necessary for this wrapper should be resolved at wrapping time, similar to how the shim does it.

@ruipin ruipin added the enhancement New feature or request label Feb 17, 2021
@ruipin ruipin closed this as completed in 932968f Apr 12, 2021
@ruipin
Copy link
Owner Author

ruipin commented Apr 12, 2021

This is now implemented in v1.5.0.0.

ruipin added a commit that referenced this issue Apr 12, 2021
ruipin added a commit that referenced this issue Apr 13, 2021
ruipin added a commit that referenced this issue Apr 13, 2021
ruipin added a commit that referenced this issue Apr 13, 2021
ruipin added a commit that referenced this issue Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant