use zlib-rs instead of linking to zlib #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is independent from the `lazy_static!` change, but seems to be somewhat (15%?) faster than calling out to zlib. my intuition is that perhaps by compiling together there's some better inlining or something, but i really don't know specifics on why this is so much faster.
|
I saw same speed or a hair slower on M4 with this change (1.05 to 1.1s with this change, 1.045 to 1.8s without). It's probably worth merging since we run on x86 in production, and this seems to be a lot faster there, especially if we include PGO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is independent from the
lazy_static!change, but seems to be somewhat (15%?) faster than calling out to zlib. my intuition is that perhaps by compiling together there's some better inlining or something, but i really don't know specifics on why this is so much faster.i've seen about 15% on a 9950x, at least, and @indirect i think has seen similar on an M4, but i hear @segiddins has seen this be slower on an M2. so might not be as clear a win. ymmv!