Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement homework 1 #774

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

juliaSnoww
Copy link

Фамилия Имя

Притыченко Юля

Email

juliasnoww@mail.ru

Номер домашнего задания

1

Ссылка на видео с демо работы

https://youtu.be/E55OnnZYuMY

Комментарии

исправленная версия комита

print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end
z-=1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surrounding space missing for operator -=.

end
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 18, 6 is not aligned with (1..j).reverse_each do |i| at 12, 2.

(1..j).reverse_each do |i|
if(i==j)
x = " "*z
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 15, 6 is not aligned with if at 13, 4.

(1..depth).each do |j|
(1..j).reverse_each do |i|
if(i==j)
x = " "*z

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Surrounding space missing for operator *.

array[0] = base_number
(1..depth).each do |j|
(1..j).reverse_each do |i|
if(i==j)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not -2) spaces for indentation.
Space after keyword if is missing.
Surrounding space missing for operator ==.

array[i] = array[i - 1] + array[i]
end
z -= 1
puts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end
z -= 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

end
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

x = ' '*z
end
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

if(i == j)
x = ' '*z
end
print "#{x}#{array[i - 1]} "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

(1..j).reverse_each do |i|
if(i == j)
x = ' '*z
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.

(1..depth).each do |j|
(1..j).reverse_each do |i|
if(i == j)
x = ' '*z

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.
Use 2 (not 1) spaces for indentation.
Surrounding space missing for operator *.

array[0] = base_number
(1..depth).each do |j|
(1..j).reverse_each do |i|
if(i == j)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.
Use 2 (not 1) spaces for indentation.
Space after keyword if is missing.

z = depth
array[0] = base_number
(1..depth).each do |j|
(1..j).reverse_each do |i|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 1) spaces for indentation.
Tab detected.

base_number = gets.to_i
array = []
(1..depth).each do |i|
array[i] = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 1) spaces for indentation.
Tab detected.

end
print "#{x}#{array[i - 1]} "
array[i] = array[i - 1] + array[i]
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 18, 3 is not aligned with (1..j).reverse_each do |i| at 12, 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants