instance level class access was removed, ask class for name instead of i... #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, I'll add a spec and then merge |
…ot assigned The spec existed to catch this issue, unfortunately it didn’t fail because the message we were testing against had a field named “name”, thus calling `self.name` in the raise string didn’t fail, it just returns nil (since the name value wasn’t set). The fix then is to create a message type with a required field named something other than `name`.
localshred
added a commit
that referenced
this pull request
Feb 26, 2014
instance level class access was removed, ask class for name instead of i...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nstance
@localshred
only place I could find this kind of prob in the message classs