Use a primitive field mapping from symbol to field class #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to generate “prettier” message code that use symbols for all the primitive types in the definition. ```ruby # old class Foo optional ::Protobuf::Field::StringField, :bar, 1 end # new class Bar optional :string, :foo, 1 end ```
| proto_path = ::File.expand_path('../spec/support/', __FILE__) | ||
| cmd = %Q{protoc --plugin=./bin/protoc-gen-ruby --ruby_out=#{proto_path} -I #{proto_path} #{File.join(proto_path, '**', '*.proto')}} | ||
| puts cmd | ||
| exec cmd | ||
| end | ||
|
|
||
| desc "Compile spec protos in spec/supprt/" |
There was a problem hiding this comment.
Looks like the description got left behind from the copy/paste.
There was a problem hiding this comment.
Good catch, updating...
|
Other than the task description, I think this looks good. Nice to have prettier output, but I also wonder what additional functionality may be gleaned from the new primitive mapping. 👍 |
|
love the new syntax, I think long term benefit could be multiple encoders/decoders thrift/message pack /avro could all come of a unified ddl |
localshred
added a commit
that referenced
this pull request
Feb 17, 2014
Use a primitive field mapping from symbol to field class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate “prettier” message code that uses symbols for all the
primitive types in the definition.
You can mostly ignore the Rakefile and *.pb.rb file changes, the relevant changes are in
lib/protobuf/field.rbandlib/protobuf/generators/field_generator.rb.