Handle encoding/coercing/validation in the encoder #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -135,7 +135,7 @@ def callable_rpc_method(method_name) | |||
| # Register a failure callback for use when rpc_failed is invoked. | |||
| # | |||
| def on_rpc_failed(callable) | |||
| @_rpc_failed_callback ||= callable | |||
| @_rpc_failed_callback = callable | |||
There was a problem hiding this comment.
I'm not sure why this would be useful, but I left it in while setting up a default. It allowed me to cleanup the dispatcher.
There was a problem hiding this comment.
I was going to mention it, it's a kind of wonky pattern (I created) with the method handle. Rather than the send, I'd just have that method return a lambda, or just set the lambda in the initializer directly. Chalk it up as another "feature" that never materialized.
There was a problem hiding this comment.
In other words, KILL IT!
Rather than having the dispatcher coerce and validate responses or handle that in a separate middleware, move it all into the encoder.
Instead of providing a callback hook that is fired when rpc_failed is called, just take the given message and raise an RPC failed error.
|
Count me a fan! 👍 |
liveh2o
added a commit
that referenced
this pull request
Feb 14, 2014
Handle encoding/coercing/validation in the encoder
|
Closes #154 |
liveh2o
added a commit
that referenced
this pull request
Feb 16, 2014
Handle encoding/coercing/validation in the encoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having the dispatcher coerce and validate responses or handle that in a separate middleware, move it all into the encoder.
This should make it easier for other middlewares to hook in before or after the coercion and validation.
// @localshred @abrandoned