Replace custom lifecycle with AS::Notifications #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why this got deleted. It was not intentional
This will warn users that Lifecycle events are being deprecated in favor of active support notifications.
|
My final question is whether or not we'll have AS::Notifications API inconsistencies between AS 3.x and 4.x. We've had problems with that in the past, and currently we don't enforce an AS version in the gemspec. |
|
Good question broheem! The lifecycle specs pass with both activesupport 3.2.16 and 4.0.2 |
|
Sweet, I'll merge tonight. |
localshred
added a commit
that referenced
this pull request
Feb 6, 2014
Replace custom lifecycle with AS::Notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #138
@localshred