[Fix #184] Fix Node#parent_module_name for sclass nodes

[dvandersluis]

Continuation of #177. I took @marcandre's tests and got them to pass. This fixes rubocop/rubocop#5022, but rubocop itself needs a PR as well because this change adds elements to the parent_module_name that it is not currently expecting.

[dvandersluis]

There's a bit of a catch 22 between this PR and rubocop/rubocop#9994. Each PR needs the other to get the tests passing.

[marcandre]

There's a bit of a catch 22 between this PR and rubocop/rubocop#9994. Each PR needs the other to get the tests passing.

Right. So either we merge this and reset the CI suite to test from the next version of RuboCop, or else we introduce some flag.

Let me see how your additional tests fail with the previous code

[marcandre]

Yeah, no flag.

So, short of introducing a list of tests that are ok to fail, I think the only way forward is:

1. merge this
2. tweak the CI suite by removing tests on RuboCop 0.92
3. release a bug fix release
   On RuboCop's side:
4. merge PR
5. bump the minimum requirement for rubocop-ast
6. release a version of RuboCop
   Back on RuboCop::AST:
7. tweak the CI suite to restore testing on that version of RuboCop

All RuboCop PRs between step 3 and 4 will have their CI fail though.

@dvandersluis do you see a better way?

[dvandersluis]

So like you said the problem is that this change will break existing tests in rubocop, even without the new tests, because the method return is going to be different.

I'm good with removing rubocop 0.92 from the test suite, since I'm not really sure why we're running against a really old rubocop anyways? However, if we need it we can always add it back when done (or maybe a more recent version?).

I think maybe a less disruptive path would be:

• Remove rubocop 0.92 from CI here, as discussed (Temporarily disable rubocop 0.92 specs in CI #198)
• On rubocop master: mark all the tests that would fail with this change as pending (Temporarily mark some Lint/DuplicateMethods specs as pending rubocop#9995)
• Merge this in
• Release rubocop-ast
• Revert the changes from (2) and bump the rubocop-ast version used by rubocop simultaneously. (Revert "Temporarily disable rubocop 0.92 specs in CI" #199)
• Update rubocop-ast CI ([Fix #5022] Fix false negative for Lint/DuplicateMethods inside class << self rubocop#9994).

If we agree with this (and are good with both this and the rubocop PR, obviously) I can do all this quickly and sequentially for minimal disruption (the only thing I don't know how to do would be to release a new version of the gem).

[marcandre]

we're running against a really old rubocop anyways

Ideally, projects with old versions of RuboCop (e.g. stuck with old versions of Ruby) can still run with newer rubocop-ast.

If we agree with this

Indeed, marking the tests as pending is the way to go 👍 Let's do this.

I'll be glad to make the release. If you create the PR to tweak the CI suite, don't forget to modify the .mergify too

[dvandersluis]

@marcandre once #198 is merged, I'll rebase and merge this PR.

[dvandersluis]

@marcandre this is ready to be merged and released now.

[marcandre]

Released 1.9.1, thanks! 👍