Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTALL-944: Improve CI pipeline to make it scalable #683

Merged
merged 10 commits into from
Apr 22, 2024

Conversation

lulivi
Copy link
Collaborator

@lulivi lulivi commented Apr 12, 2024

Summary

The current CI state of the examples repository consists in building all the examples in 4 build modes:

  • Release build with dynamic library linking
  • Release build with static library linking
  • Debug build with dynamic library linking
  • Debug build with static library linking

This PR make the Jenkinsfile simpler and adds some enhancements to allow building the examples in other platforms rather than Linux docker nodes.

Details and comments

Checks

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@lulivi lulivi requested a review from ManuelJNunez April 12, 2024 14:18
@lulivi lulivi changed the title INSTALL-944: Improve CI pipeline to make it scalable WIP: INSTALL-944: Improve CI pipeline to make it scalable Apr 12, 2024
@lulivi lulivi changed the title WIP: INSTALL-944: Improve CI pipeline to make it scalable INSTALL-944: Improve CI pipeline to make it scalable Apr 18, 2024
Copy link
Member

@ManuelJNunez ManuelJNunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the other comments.

@ManuelJNunez ManuelJNunez self-requested a review April 22, 2024 07:28
ManuelJNunez
ManuelJNunez previously approved these changes Apr 22, 2024
@ManuelJNunez
Copy link
Member

ManuelJNunez commented Apr 22, 2024

  • Should we merge to develop instead?

Copy link
Member

@ManuelJNunez ManuelJNunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer my question before merging

@lulivi lulivi changed the base branch from master to develop April 22, 2024 13:19
@lulivi lulivi merged commit 735a566 into rticommunity:develop Apr 22, 2024
1 check passed
@lulivi lulivi deleted the feature/INSTALL-944 branch May 16, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants