Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-13335: Fix examples that assume invalid data cannot be ALIVE #668

Merged

Conversation

samuelraeburn
Copy link
Contributor

Summary

Update the keyed_data example that assumes that !valid_data means an instance cannot be ALIVE.

Details and comments

The introduction of Instance State Consistency means that a sample without valid_data can be in any instance state.
The following code is no longer correct:

if (!valid_data)
     if (instance_state == NOT_ALIVE_DISPOSED) {
         // handle disposed
     } else {
         // handle NOT_ALIVE_NO_WRITERS
     }

Checks

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Sam Raeburn added 5 commits February 22, 2024 11:44
(cherry picked from commit 320539c)
(cherry picked from commit 2a6219a)
(cherry picked from commit e2a1cbf)
(cherry picked from commit ada2dca)
@samuelraeburn samuelraeburn merged commit a0bd5c2 into rticommunity:release/7.3.0 Mar 1, 2024
2 checks passed
@samuelraeburn samuelraeburn deleted the feature/CORE-13335-730 branch March 1, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants