Improve documentation in Recording examples so the CMake command always works #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgallegosalido
changed the title
Antoniolm
previously approved these changes
Feb 22, 2024
Antoniolm
approved these changes
Feb 22, 2024
alvinkrebs
added a commit
that referenced
this pull request
Apr 11, 2024
…e to master. (#682) * Add dynamic_data_skip_serialization example (#642) Add dynamic_data_skip_serialization example for C++11 and Python. This is an upcoming feature in Connext DDS 7.3.0. * Fix Web Integration Service library api example by using the webserver_option() function instead of the old document_root() function * Fix formatting * COMMUNITY-81 | Move GH Actions CI to Jenkins (#650) * COMMUNITY-81: move GH Actions CI to Jenkins * COMMUNITY-81: refactor Jenkinsfile * COMMUNITY-81: update dockerfile name * COMMUNITY-81: install python dependencies * COMMUNITY-81: use pip3 instead of pip * COMMUNITY-81: use pip3 instead of pip * COMMUNITY-81: change connextdds installation path * COMMUNITY-81: change timeout * #651 #655: Fix overflow and eof issue * filter-out removed files from linux_format.py fix #633 (#663) * execute linters on release branches as well fixes #665 (#666) * CORE-13335: Fix examples that assume invalid data cannot be ALIVE (cherry picked from commit b89cfb8) * CORE-13335: Fix linting errors (cherry picked from commit 320539c) * CORE-13335: Apply lint patch file (cherry picked from commit 2a6219a) * CORE-13335: PR feedback (cherry picked from commit e2a1cbf) * CORE-13335: Apply lint patch (cherry picked from commit ada2dca) * Improve documentation in Recording examples so the CMake command always works (#667) * Improve documentation in Recording examples so the CMake command always works * Remove trailing spaces --------- Co-authored-by: Francisco Gallego Salido <fgallego@rti.com> * Remove status badge from README fixes #659 (#660) * Fix Routing Service file adapter examples * ROUTING-1182: adding cross-compilation instructions where missing for Infrastructure Services * Update VERSION for release/7.3.0 fix #677 (#678) * Use new property names and values in the lightweight and cds examples (#672) (#679) * Use new property names in the lightweight and cds examples * schema url updates * Fix linting * #fix IRONSIDE-763 -- change version to 7.3.0 in csproj files, and update README ... (#680) (#681) --------- Co-authored-by: Alex Campos <alejandro@rti.com> Co-authored-by: Francisco Gallego Salido <fgallego@rti.com> Co-authored-by: Fernando García Aranda <fgarcia@rti.com> Co-authored-by: Manuel Jesús Núñez Ruiz <manueljesusnunezruiz@gmail.com> Co-authored-by: Antonio Lopez <alopez@rti.com> Co-authored-by: lulivi <luislivilla@gmail.com> Co-authored-by: Sam Raeburn <sam@rti.com> Co-authored-by: Francisco Gallego Salido <fgallegosalido@gmail.com> Co-authored-by: Sam <raeburnsamuel@gmail.com> Co-authored-by: Juan Luis Jimenez Simon <juan@rti.com> Co-authored-by: Luis Colmenero <colmenero@rti.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve the documentation in the recording examples so that the CMake command to build them always works.
Details and comments
Added the variables
CONNEXTDDS_DIRandCONNEXTDDS_ARCHto the CMake build command.Checks